He was the editor of Seren Gomer from 1921 to 1930, and from 1933 until 1947 (with John Gwili Jenkins, DWB, 435-6, for a year, and then with David Hopkins as co-editors). He was a notable administrator — he was President of his cymanfa, President of the Union of Welsh Baptists, 1939-40, and Chairman of the Baptist Missionary Society, 1944-45. He contributed many articles to Y Genhinen, Seren Gomer and to the transactions of the Historical Society of Welsh Baptists, as well as a volume on the history of the Baptists in Clydach, and one on the history of the parish of Llangyfelach.

His theology was that of the orthodox tradition of the old Nonconformity of the 18th century, but he became profoundly influenced by the Cymru Fydd movement, and believed firmly in the importance of the Welsh language — he held classes in Welsh in his church in Maesteg, a rarity at that time. He won the prose medal at the Llangollen eisteddfod in 1908, and, when the eisteddfod came to Llanelli in 1930 he was the secretary of the Literature Committee, and deputy secretary of the eisteddfod. He was a member of the Gorsedd, under the name of ‘Glanlliw’. He was the chairman of the Poetry and Music Club of the town for many years, and during World War II he was Chairman of Undeb Cymru Fydd in the area. He owned a wide-ranging and valuable library, and was an authority on first editions.

On 12 Sept. 1905, in Tabernacl, Maesteg, he m. Jane, the daughter of David and Elizabeth (née Jenkins) Williams. She d. on 14 Dec. 1936 and he on 16 Dec. 1947, and they were both buried in the Box cemetery, Llanelli. They had one daughter.